Merged
Conversation
Member
ezio-melotti
left a comment
There was a problem hiding this comment.
Have you tried checking this on a paragraph with lot of dunders?
ISTM that with 0.2em the underline touches the underscores.
Maybe 0.25em would be a good comprise?
Member
Author
|
Here's a link to the build preview of that section: There is a small gap between the underscore and underline (Android/Chrome): |
Member
Author
Member
Member
Author
|
0.25em looks okay to me, PR updated. |
ezio-melotti
approved these changes
Jan 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










We added underlines in #160, with an offset to make sure they don't obscure underscores in code formatting. With fresh eyes, 0.3em looks a bit too much. Let's reduce it.
0.3em
0.2em